Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #486 #487

Merged
merged 41 commits into from
Oct 5, 2023

Update per PR

408012b
Select commit
Loading
Failed to load commit list.
Merged

Fixes #486 #487

Update per PR
408012b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 5, 2023 in 1s

91.10% (+0.21%) compared to 530e969

View this Pull Request on Codecov

91.10% (+0.21%) compared to 530e969

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (530e969) 90.88% compared to head (408012b) 91.10%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #487      +/-   ##
============================================
+ Coverage     90.88%   91.10%   +0.21%     
- Complexity     1596     1626      +30     
============================================
  Files           318      319       +1     
  Lines          4489     4553      +64     
  Branches        369      377       +8     
============================================
+ Hits           4080     4148      +68     
+ Misses          282      276       -6     
- Partials        127      129       +2     
Files Coverage Δ
...org/xrpl/xrpl4j/codec/addresses/AddressBase58.java 94.00% <100.00%> (+4.00%) ⬆️
.../org/xrpl/xrpl4j/codec/addresses/AddressCodec.java 85.71% <ø> (ø)
...g/xrpl/xrpl4j/codec/addresses/PrivateKeyCodec.java 100.00% <100.00%> (ø)
...rg/xrpl/xrpl4j/codec/addresses/PublicKeyCodec.java 100.00% <100.00%> (ø)
.../org/xrpl/xrpl4j/codec/addresses/UnsignedByte.java 87.50% <100.00%> (+3.62%) ⬆️
...xrpl/xrpl4j/codec/addresses/UnsignedByteArray.java 100.00% <ø> (ø)
.../java/org/xrpl/xrpl4j/codec/addresses/Version.java 100.00% <100.00%> (ø)
...in/java/org/xrpl/xrpl4j/crypto/keys/PublicKey.java 100.00% <100.00%> (ø)
...ava/org/xrpl/xrpl4j/crypto/keys/bc/BcKeyUtils.java 82.45% <100.00%> (-0.88%) ⬇️
...pl4j/crypto/signing/AbstractTransactionSigner.java 91.66% <ø> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.