Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [feature] Add tampered_sensors partition attribute #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XaF
Copy link
Owner

@XaF XaF commented Jan 8, 2023

This allows to escalate to the partition the tampered status of sensors, which might make it easier to use than the per-sensor attribute flag.

@github-actions

This comment has been minimized.

This allows to escalate to the partition the tampered status of
sensors, which might make it easier to use than the per-sensor
attribute flag.
@XaF XaF force-pushed the xaf/escalate_tampered_sensor_to_partition_attribute branch from 6424c25 to 4b6dcef Compare January 8, 2023 23:07
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py170100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py238797%164, 212, 215, 333, 384, 467, 545
   utils.py50100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py701381%63–64, 66, 70, 75, 90–102, 112, 120, 146
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%64, 69, 100, 104, 130–131, 163, 167, 190, 201, 208, 235, 251, 265, 278–280, 325, 357, 369, 414
   exceptions.py290100% 
   observable.py17194%13
   partition.py139795%177–181, 188–192, 195
   sensors.py2052090%57–78, 136, 194, 198, 205, 222, 226
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py64395%24, 74, 82
   utils.py47491%11, 14, 20–21
TOTAL156814391% 

Tests Skipped Failures Errors Time
118 0 💤 0 ❌ 0 🔥 31.069s ⏱️

@XaF
Copy link
Owner Author

XaF commented Jan 17, 2023

Wondering if this makes sense, or if it'd be better to create a tamper sensor for each partition (Home Assistant tamper device class) which would bubble up that information and be "open" if any sensor of the partition is currently opened instead of being in an attribute of the partition. The tampered sensors could be listed in the attributes of that tamper sensor.

Thinking about it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant