Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose cleanup #2248

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Jun 23, 2024

  1. refactor: Docker secrets in .env

    - Separate values into Ports and User/Password section
    - Apply alphabetical sorting, thank Copilot.
    Jamie-Clayton committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    e75b94a View commit details
    Browse the repository at this point in the history
  2. docs: Include instructions for running tests locally

    - Include simple docker compose instructions.
    - Uncovered automated tests failed locally, due to container status != running.
    - Tests do take a while to execute locally.
    Jamie-Clayton committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    86e6adc View commit details
    Browse the repository at this point in the history
  3. build: Include yaml-language-server reference in docker-compose

    - Provides a better developer experience in Visual Studio 2022 and Visual Code
    - Recommend: Install the Redhat Yaml extension in Visual Code
    Jamie-Clayton committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    33bd4b0 View commit details
    Browse the repository at this point in the history
  4. test: Ensure Microsoft SQL Server tests pass with docker

    - Fixed a copy and paste typo with the Port
    Jamie-Clayton committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    ad9dc7b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fcca603 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. docs: Update the Running tests locally section

    * Include a discussion on the use of sensitive data in docker compose.
    * Move to the end of the readme file.
    Jamie-Clayton committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    75a4ac3 View commit details
    Browse the repository at this point in the history