#2178 Added a new method CreateResponseWriter to UIResponseWriter #2307
+47
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
…ter class. Cleanup some duplicated code.
terjew
force-pushed
the
2178-support-custom-jsonoptions-in-uiresponsewriter
branch
from
744c26b
to
37ddd44
Compare
|
@Alirexaa how do I get a reviewer assigned to this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Makes it possible for other projects to reuse UIResponseWriter even if they have other needs with regards to serialization options.
Which issue(s) this PR fixes:
#2178
Special notes for your reviewer:
Do I need to document the functionality? A sample use case can be seen in the unit test.
All the tests from UI.Client and UI.Core run fine, which is what I would expect to be affected by the changes.
Many tests from other projects do not run successfully on my local setup, but that is also true before applying my changes. I assume I am missing some dependency, configuration or similar. It seems like there is a CI workflow to run tests in GitHub, but it is waiting for approval before it will run.
Does this PR introduce a user-facing change?:
The proposed change should only affect library users, not end-users.
Please make sure you've completed the relevant tasks for this PR, out of the following list: