Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AGPL license #1565

Merged
merged 8 commits into from
Sep 6, 2024
Merged

Add AGPL license #1565

merged 8 commits into from
Sep 6, 2024

Conversation

Xeeynamo
Copy link
Owner

@Xeeynamo Xeeynamo commented Aug 22, 2024

From the public announcement on Discord:

We've been progressing very far with the project and I started wondering what would be the best course of action to protect the work of existing and future contributors. I personally consider contributions to a decompilation project as creative work. Therefore it is my desire to protect this creative work from being re-claimed by other people. This is especially true in the light of the ability of modding the existing decompiled code and create derivative work.

I talked privately with the current most active contributors. And me, @sozud , @bismurphy and @joshlory so far agreed on pushing through the AGPLv3 license for all the decompiled code in sotn-decomp/src, excluding any third party code and decompiled code from the PSX SDK. But I've been wanting to ask all of you if you are fine your code to be licensed and protected under the AGPLv3 terms.

https://raw.githubusercontent.com/Xeeynamo/sotn-decomp/89686514916cabd0dd88ae0387f749a889c19e05/src/LICENSE

I put and all the contributors, which can be accessed to the page https://github.com/Xeeynamo/sotn-decomp/graphs/contributors . Again, this will work for existing and future contributors. In the license I put my full name as I will be responsible of any legality. And I understand not every contributor wants to disclose their identity. Please give an approval to my latest PR if you do not have any objection. If not, please write here publicly.

PS. I understand past contributors will either not see the message above or decide to ignore it. If I do not hear from anyone of the contributors for more than one week between those who did not interact with me or the server, I will still go ahead and apply the license. It is not in my intention to ignore past contributors. But I do not want contributors who have been inactive for months or years to be a blocker. Please do not mistake this as an act of malevolence.

tools/lint-license.py Outdated Show resolved Hide resolved
@Xeeynamo Xeeynamo changed the title Adds AGPL license Add AGPL license Aug 22, 2024
@@ -1,3 +1,4 @@
// SPDX-License-Identifier: AGPL-3.0-only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you aren't excluding psxsdk

@@ -1,3 +1,4 @@
// SPDX-License-Identifier: AGPL-3.0-only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't relicense this

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsie, I will exclude this folder too

@@ -1,3 +1,4 @@
// SPDX-License-Identifier: AGPL-3.0-only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/saturn/lib should be excluded

src/LICENSE Outdated
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published
// by the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license doesn't match the tag you picked AGPL-3.0-only

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KiritoDv
Copy link

KiritoDv commented Aug 23, 2024

I suggest you should do something like this n64decomp/mk64#474 since you need to every single one of the 30 contributors to accept the license change explicitly, and something personal, since this is a decomp i dont think that is the correct license, it should be cc0, ( If someone doesnt accept, you can't license its code )

@sozud
Copy link
Collaborator

sozud commented Aug 23, 2024

it should be cc0

CC0 doesn't seem to be OSI approved so I wouldn't recommend it https://opensource.org/licenses

Edit: https://opensource.org/faq#cc-zero

@sozud
Copy link
Collaborator

sozud commented Aug 24, 2024

@sonicdcer What licenses are you willing to accept?

@sozud
Copy link
Collaborator

sozud commented Aug 24, 2024

I figure I should explain more why I think AGPLv3 makes sense vs. CC0 since there's a number of decomp projects that have chosen it or are working on re-licensing to it.

https://github.com/sonicdcer/sf64?tab=CC0-1.0-1-ov-file#readme
n64decomp/mk64#474
https://github.com/n64decomp/sm64?tab=CC0-1.0-1-ov-file

AGPLv3 is a strong copyleft license which means that people must release their modifications to the source. This keeps the project maximally open to the community so everyone can benefit from those modifications.

AGPLv3 has a disclaimer of warranty, and limits liability, which protects the contributors.

AGPLv3 has a patent license, which protects users of the software from being sued for violating patents.

@sozud
Copy link
Collaborator

sozud commented Aug 29, 2024

@ser-pounce @rossimo @frog404 Any issues with this change?

@ser-pounce
Copy link
Contributor

@sozud all good, thanks for asking!

@rossimo
Copy link
Contributor

rossimo commented Aug 29, 2024

I'm all good

@sozud
Copy link
Collaborator

sozud commented Aug 29, 2024

Current status for ./src (the part we are trying to re-license) is the following. This list isn't perfect since it includes psxsdk, which we aren't trying to re-license at this time. Generated with git shortlog -n -s -- src

*  821  Luciano Ciccariello
*  382  bismurphy
*  290  sozud
   159  Alejandro Asenjo Nitti
*   49  Jonathan Hohle
*   38  Josh Lory
*   32  ser-pounce
*   21  SestrenExsis
*   16  SynaMax
*   14  Julien Augugliaro
*   12  Allison Mackenzie Johnson
*    8  Mark Street
*    8  Ross Squires
     5  frog404
     4  Tuomas Tynkkynen
*    3  NotExactlySiev
     2  piratesephiroth
     1  Javier Córdoba Romero
     1  MottZilla
     1  Rainchus
     1  smb123w64gb

@dezgeg @piratesephiroth @kpanicc @MottZilla @Rainchus @smb123w64gb Any issues with this change?

@kpanicc
Copy link
Contributor

kpanicc commented Aug 29, 2024

All good, thank you for asking!
@sozud

@frog404
Copy link
Contributor

frog404 commented Aug 29, 2024

All good for me too 👌
I feel it was an eternity ago that I did my modest PRs... You people are doing an amazing job !
Thanks for that and have a great day

@dezgeg
Copy link
Contributor

dezgeg commented Aug 29, 2024

Fine by me

@smb123w64gb
Copy link
Contributor

No issue here.

@Xeeynamo
Copy link
Owner Author

@sonicdcer I kindly ask you to provide your feedback. For legal purposes we need a public record here.

@sozud
Copy link
Collaborator

sozud commented Sep 3, 2024

sonicdcer asked me to delete a previous version of this comment since it included some info that wasn't pertinent to the license discussion, so I am re-posting:

He requests that src/LICENSE be removed since the root directory LICENSE (full AGPLv3) is sufficient in his opinion. His concern is that explicitly naming individuals takes away from the group nature of the project.

@Max-Clark
Copy link
Contributor

AGPL sounds great to me 👍

@sonicdcer
Copy link
Contributor

I agree to license all my contributions to AGPLv3.

@bismurphy bismurphy merged commit 4870071 into master Sep 6, 2024
16 checks passed
@bismurphy bismurphy deleted the license branch September 6, 2024 20:14
@Rainchus
Copy link
Contributor

Rainchus commented Sep 7, 2024

I agree to license my contributions with AGPLv3

@MottZilla
Copy link
Contributor

@dezgeg @piratesephiroth @kpanicc @MottZilla @Rainchus @smb123w64gb Any issues with this change?

I have no issues with the change. License is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.