-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AGPL license #1565
Add AGPL license #1565
Conversation
src/main/psxsdk/libapi/a07.c
Outdated
@@ -1,3 +1,4 @@ | |||
// SPDX-License-Identifier: AGPL-3.0-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you aren't excluding psxsdk
src/pc/3rd/cJSON/cJSON.c
Outdated
@@ -1,3 +1,4 @@ | |||
// SPDX-License-Identifier: AGPL-3.0-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't relicense this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oopsie, I will exclude this folder too
src/saturn/lib/gfs.c
Outdated
@@ -1,3 +1,4 @@ | |||
// SPDX-License-Identifier: AGPL-3.0-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/saturn/lib should be excluded
src/LICENSE
Outdated
// This program is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU Affero General Public License as published | ||
// by the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license doesn't match the tag you picked AGPL-3.0-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted and copied from https://spdx.org/licenses/AGPL-3.0-only.html
I suggest you should do something like this n64decomp/mk64#474 since you need to every single one of the 30 contributors to accept the license change explicitly, and something personal, since this is a decomp i dont think that is the correct license, it should be cc0, ( If someone doesnt accept, you can't license its code ) |
CC0 doesn't seem to be OSI approved so I wouldn't recommend it https://opensource.org/licenses |
@sonicdcer What licenses are you willing to accept? |
I figure I should explain more why I think AGPLv3 makes sense vs. CC0 since there's a number of decomp projects that have chosen it or are working on re-licensing to it. https://github.com/sonicdcer/sf64?tab=CC0-1.0-1-ov-file#readme AGPLv3 is a strong copyleft license which means that people must release their modifications to the source. This keeps the project maximally open to the community so everyone can benefit from those modifications. AGPLv3 has a disclaimer of warranty, and limits liability, which protects the contributors. AGPLv3 has a patent license, which protects users of the software from being sued for violating patents. |
@ser-pounce @rossimo @frog404 Any issues with this change? |
@sozud all good, thanks for asking! |
I'm all good |
Current status for
@dezgeg @piratesephiroth @kpanicc @MottZilla @Rainchus @smb123w64gb Any issues with this change? |
All good, thank you for asking! |
All good for me too 👌 |
Fine by me |
No issue here. |
@sonicdcer I kindly ask you to provide your feedback. For legal purposes we need a public record here. |
sonicdcer asked me to delete a previous version of this comment since it included some info that wasn't pertinent to the license discussion, so I am re-posting: He requests that src/LICENSE be removed since the root directory LICENSE (full AGPLv3) is sufficient in his opinion. His concern is that explicitly naming individuals takes away from the group nature of the project. |
AGPL sounds great to me 👍 |
I agree to license all my contributions to AGPLv3. |
excluding: * src/3rd * src/main/psxsdk * src/pc/psxsdk
I agree to license my contributions with AGPLv3 |
I have no issues with the change. License is fine. |
From the public announcement on Discord: