-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XRTRunner Utility Class & Programming Examples Cleanup #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunhoffe
force-pushed
the
xrt-runner-utility
branch
from
July 19, 2024 22:34
1621b9b
to
7d3f247
Compare
hunhoffe
changed the title
WIP: XRTRunner Utility Class & Programming Examples Cleanup
XRTRunner Utility Class & Programming Examples Cleanup
Jul 29, 2024
This was referenced Jul 30, 2024
jgmelber
approved these changes
Jul 31, 2024
fifield
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
XRTRunner
class, which is used to run programs on the npu while using common numpy operations to check the input/outputdata_transfer_transpose
to run for both float and int 32-bit datatypesmatrix_scalar_add
examplematrix_scalar_add/multi_launch_channel
example would not compile; but then a recent PR (Fixup data layout in programming examples #672) fixed that issue. However, the code as-is was in an intermediate state (testing something simple before full implementation) so it didn't truly fix the issue. I've updated the code so the implementation is correct; we now get a failure with the complete code. I've marked the test as a failure and will re-open the multi-launch issue (Multiple launches, herd with single core #627)The
XRTRunner
class does truly reduce the number of lines of code; however, as I improved the ability to configure examples (and add documentation, etc.) these things added back a lot of lines of code to this PR so the improvement isn't immediately obvious in the git LoC counts.