Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRTRunner Utility Class & Programming Examples Cleanup #673

Merged
merged 37 commits into from
Jul 31, 2024

Conversation

hunhoffe
Copy link
Collaborator

@hunhoffe hunhoffe commented Jul 19, 2024

This PR:

  • Introduces the XRTRunner class, which is used to run programs on the npu while using common numpy operations to check the input/output
  • Remove spaghetti python path logic in examples
  • Allows the data_transfer_transpose to run for both float and int 32-bit datatypes
  • Makes it easier to change the sizes of things in the matrix_scalar_add example
  • Percolate changes from Fixup data layout in programming examples #672 to other programming examples as appropriate
  • Remove relative paths in makefiles
  • Previously, the matrix_scalar_add/multi_launch_channel example would not compile; but then a recent PR (Fixup data layout in programming examples #672) fixed that issue. However, the code as-is was in an intermediate state (testing something simple before full implementation) so it didn't truly fix the issue. I've updated the code so the implementation is correct; we now get a failure with the complete code. I've marked the test as a failure and will re-open the multi-launch issue (Multiple launches, herd with single core #627)
  • Adds/updates READMEs

The XRTRunner class does truly reduce the number of lines of code; however, as I improved the ability to configure examples (and add documentation, etc.) these things added back a lot of lines of code to this PR so the improvement isn't immediately obvious in the git LoC counts.

@hunhoffe hunhoffe changed the title WIP: XRTRunner Utility Class & Programming Examples Cleanup XRTRunner Utility Class & Programming Examples Cleanup Jul 29, 2024
@hunhoffe hunhoffe marked this pull request as ready for review July 30, 2024 16:27
Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@hunhoffe hunhoffe merged commit 2c3fcf4 into main Jul 31, 2024
11 checks passed
@hunhoffe hunhoffe deleted the xrt-runner-utility branch July 31, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants