Make ONNX to TOSA conversion resistant to dynamic types #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorickert
force-pushed
the
jrickert.onnx-to-tosa-dyn
branch
from
e84d51f
to
ab42a8b
Compare
jorickert
changed the title
jorickert
force-pushed
the
jrickert.onnx-to-tosa-dyn
branch
2 times, most recently
from
5426dc8
to
02d9b38
Compare
…n because of unraked operand types
…t run because of failed shape inference
jorickert
force-pushed
the
jrickert.onnx-to-tosa-dyn
branch
from
02d9b38
to
6baa9b2
Compare
flemairen6
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists out of two parts:
computeShapeand check its return value instead ofcomputeShapeAndAssertOnFailurein the ONNX to TOSA lowering, to prevent crashes in the presence of dynamic typesgetShapedTypeRank. Check in these if the type is ranked and return a failure otherwise. (Not reporting an error, as this does not mean that the operation is malformed, just that its input is not ranked). Maybe upstream this change