Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle invalid batchprocess revisions #1265

Merged
merged 2 commits into from
Nov 29, 2024
Merged

handle invalid batchprocess revisions #1265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efb5e8b
handle invalid batchprocess revisions
LukasFey-GIP Nov 20, 2024
d65e66e
Merge branch 'main' into 1254-handle-exceptions-when-checking-revisio…
LukasFey-GIP Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion server/src/com/gip/xyna/xprc/xbatchmgmt/BatchProcess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/
package com.gip.xyna.xprc.xbatchmgmt;

import java.util.Objects;
import java.util.Random;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.CountDownLatch;
Expand Down Expand Up @@ -803,7 +804,13 @@ public boolean isTimedout() {
* @return
*/
public boolean isInRevision(Long revision) {
return batchProcessArchiveData.getRevision().equals(revision);
Long batchProcessRevision = null;
try {
batchProcessRevision = batchProcessArchiveData.getRevision();
} catch (IllegalArgumentException e) {
return false;
}
return Objects.equals(batchProcessRevision, revision);
}


Expand Down