dbus: DisplayConfig: support monitor configuration #912
Conversation
src/dbus/mutter_display_config.rs
Outdated
| @@ -45,6 +82,137 @@ pub struct LogicalMonitor { | |||
|
|
|||
| #[dbus_interface(name = "org.gnome.Mutter.DisplayConfig")] | |||
| impl DisplayConfig { | |||
| async fn get_resources( | |||
There was a problem hiding this comment.
Is this method actually needed? The panel shows up as is for me, and I cannot actually find any calls to GetResources in gnome-control-center: https://gitlab.gnome.org/search?search=GetResources&nav_source=navbar&project_id=660&group_id=8&search_code=true&repository_ref=main
There was a problem hiding this comment.
The thing that calls it is gnome-rr but I forgot where I encountered usage of that API… ah. Not for Settings, but it's required for gsd-color. I'd like to get Night Light working, at least via an external client that would read g-s-d's temperature output and do wlr-gamma-control-unstable-v1 based on it, but for that gsd-color must actually work
There was a problem hiding this comment.
Bumping. Could you remove this change from this PR?
valpackett
force-pushed
the
push-qpmvznoktkvn
branch
3 times, most recently
from
d0f738b to
9291b91
Compare
|
Fixed commit descriptions, improved style according to discussions above, rebased on top of the zbus 5 changes, added fractional scales 🚀 |
src/dbus/mutter_display_config.rs
Outdated
| @@ -45,6 +82,137 @@ pub struct LogicalMonitor { | |||
|
|
|||
| #[dbus_interface(name = "org.gnome.Mutter.DisplayConfig")] | |||
| impl DisplayConfig { | |||
| async fn get_resources( | |||
There was a problem hiding this comment.
Bumping. Could you remove this change from this PR?
niri-ipc/src/lib.rs
Outdated
| @@ -800,6 +800,22 @@ pub enum Transform { | |||
| Flipped270, | |||
| } | |||
|
|
|||
| impl Transform { | |||
| /// Return numeric identifier matching the `transform` enum of the `wl_output` interface. | |||
| pub fn to_wayland_id(self) -> u32 { | |||
There was a problem hiding this comment.
This is not a "to wayland id", this is a "to mutter-specific private dbus interface id". So it should be left inside mutter_display_config.rs.
There was a problem hiding this comment.
The actual numbers do match wayland.xml, not sure why you think mutter could ever switch to different numbers 🙄
There was a problem hiding this comment.
It couldn't. But this code was written specifically to convert according to the mutter xml, and isn't used anywhere else
src/dbus/mutter_display_config.rs
Outdated
| connector | ||
| ))); | ||
| } | ||
| let msgs = vec
This is required for gnome-control-center to be able to turn monitors back on.
valpackett
force-pushed
the
push-qpmvznoktkvn
branch
2 times, most recently
from
7e9b5aa to
8c22145
Compare
This enables gnome-control-center to apply display configuration changes. Only temporarily, persistence is ignored currently.
valpackett
force-pushed
the
push-qpmvznoktkvn
branch
from
8c22145 to
2b56418
Compare
happy new year 🎉 this here PR extends the org.gnome.Mutter.DisplayConfig implementation enough to make the GNOME display settings work
niri-gnome-monitor-settings.webm
(
XDG_CURRENT_DESKTOP=gnome gnome-control-center)