Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check sematically equivalent modules #782

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

bskqd
Copy link
Contributor

@bskqd bskqd commented Jun 2, 2023

added notifying vendors about semantically different modules in vendor dirs, which should be merged only after YangCatalog/deployment#197 and mbj4668/pyang#857

resolves #748

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #782 (8ec5950) into develop (428063c) will increase coverage by 0.12%.
The diff coverage is 83.69%.

❗ Current head 8ec5950 differs from pull request most recent head 6d9428e. Consider uploading reports for the commit 6d9428e to get more accurate results

@@             Coverage Diff             @@
##           develop     #782      +/-   ##
===========================================
+ Coverage    77.74%   77.86%   +0.12%     
===========================================
  Files          110      110              
  Lines        11393    11649     +256     
===========================================
+ Hits          8857     9071     +214     
- Misses        2536     2578      +42     
Impacted Files Coverage Δ
parseAndPopulate/populate.py 81.11% <ø> (ø)
utility/util.py 69.03% <14.70%> (-11.46%) ⬇️
parseAndPopulate/groupings.py 71.96% <78.00%> (+2.77%) ⬆️
parseAndPopulate/file_hasher.py 78.41% <93.33%> (+4.96%) ⬆️
parseAndPopulate/modules.py 85.00% <100.00%> (+0.51%) ⬆️
parseAndPopulate/parse_directory.py 98.94% <100.00%> (ø)
tests/test_groupings.py 98.34% <100.00%> (+0.90%) ⬆️
tests/test_parse_directory.py 94.65% <100.00%> (ø)
utility/staticVariables.py 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify vendors about conflicting modules
2 participants