Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated min(..) & max(..) macros #123

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

gavanderhoorn
Copy link
Collaborator

As per subject.

The are already provided by motoPlus.h in the M+ SDK.

Already provided by motoPlus.h in the M+ SDK.
@gavanderhoorn gavanderhoorn added this to the 0.1.1 milestone Aug 15, 2023
Copy link
Collaborator

@ted-miller ted-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to agree with this. I know I've had issues with min/max before and am confident that these were added intentionally. But... I did just verify that they exist in motoplus.h for each controller generation.

@ted-miller ted-miller merged commit fa34cee into main Aug 15, 2023
13 checks passed
@ted-miller ted-miller deleted the duplicate_min_max_macros branch August 15, 2023 17:51
@gavanderhoorn
Copy link
Collaborator Author

Yes, I remember you adding these (about two years ago).

It's indeed in all versions of motoPlus.h we use, so it didn't seem like we should keep it around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants