-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump complete cfg after parsing it #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid issues with const char*s.
Makes it easier to spot empty / misparsed settings.
Tested this on the YRC here. Output: Click to expand
|
ted-miller
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #84. This also adds the namespaces to the keys and refactors things slightly.
This is based on the work of @SejalBehere, but I've removed the changes to how things are parsed (ie: the
QoSMapping
and related types and functions are no longer used).I decided to rework the PR a bit as it mixed two different things: we may want to extend the nr of supported QoS profiles in the future, but for now we're only interested in pretty-printing the complete configuration
struct
. That's what #33 asks for.Functionally, this is largely equivalent to what @SejalBehere implemented in #84.
So thanks @SejalBehere for the work 👍