Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FJT: disable broken goal tolerance check temporarily #237

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ActionServer_FJT.c
Original file line number Diff line number Diff line change
Expand Up @@ -502,9 +502,9 @@ void Ros_ActionServer_FJT_Goal_Complete(GOAL_END_TYPE goal_end_type)
{
diff = fabs(feedback_FollowJointTrajectory.feedback.desired.positions.data[axis] - feedback_FollowJointTrajectory.feedback.actual.positions.data[axis]);

double posTolerance = g_actionServer_FJT_SendGoal_Request.goal.goal_tolerance.data[axis].position; //user-provided a goal_tolerance
if (posTolerance == 0.0) //user did NOT provide a tolerance
posTolerance = DEFAULT_FJT_GOAL_POSITION_TOLERANCE;
//ignore goal tolerance provided by user (https://github.com/Yaskawa-Global/motoros2/issues/233)
//TODO(gavanderhoorn): properly implement goal_tolerance parsing and checking
double posTolerance = DEFAULT_FJT_GOAL_POSITION_TOLERANCE;

if (diff > posTolerance)
{
Expand Down
Loading