Allow the user to insert USB with config file after bootup #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavanderhoorn
requested changes
Sep 6, 2024
Not really. We just tell people to insert the USB while the controller is powered down. That's primarily for safety reasons of opening the cabinet while powered up. We already continuously poll the SRAM for a file. I don't see any reason why we shouldn't poll USB too. |
gavanderhoorn
approved these changes
Sep 6, 2024
|
Note: I haven't tested this. |
gavanderhoorn
requested changes
Sep 6, 2024
Co-authored-by: G.A. vd. Hoorn <[email protected]>
gavanderhoorn
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #277, I inserted the USB after bootup. It didn't recognize my config file until I rebooted.