Add ListInformJobs service definition
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavanderhoorn
commented
Jul 22, 2024
gavanderhoorn
commented
Jul 22, 2024
ted-miller
previously approved these changes
Jul 22, 2024
gavanderhoorn
force-pushed
the
inform_list
branch
from
5a3cdf8 to
314348e
Compare
|
@ted-miller: PTAL |
gavanderhoorn
force-pushed
the
inform_list
branch
from
314348e to
6d1fb23
Compare
gavanderhoorn
changed the title
ListJobs service definitionListInformJobs service definition
|
@ted-miller: renamed the service definition to align better with the intended usage (and the ROS API service name). |
Part of INFORM Job CRUD.
gavanderhoorn
force-pushed
the
inform_list
branch
from
6d1fb23 to
e6d75c5
Compare
gavanderhoorn
force-pushed
the
inform_list
branch
from
7c7c0dd to
7a557c5
Compare
gavanderhoorn
force-pushed
the
inform_list
branch
from
7a557c5 to
60db96b
Compare
|
Thanks @ted-miller 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of INFORM Job CRUD and needed for Yaskawa-Global/motoros2#279.
This is a bit of a 'discussion' PR as I'm not completely sure about the design yet.