This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
Error with "OR" conditions on Workflows #14703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both conditions must be true, because if you only put "OR" conditions, the variable $finalResult will always be true since it is not modified anywhere else.
Black Duck Security ReportMerging #14703 into developer will increase security risk! Added ComponentsMedium Risk: 3 Removed ComponentsClean: 161 |
mariuszkrzaczkowski
added
the
👮♂️ VerificationRequired
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both conditions must be true, because if you only put "OR" conditions, the variable $finalResult will always be true since it is not modified anywhere else.
Testing
Creating a Workflow only with OR conditions and other with AND and OR conditions
Changes
Final checklist