Call cancelAnimationFrame
on game end/crash
#508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g_StartUpState
variable). Consequently, the same error-inducing code would execute at eachrequestAnimationFrame
call.Basically, a code snippet like this in a Create Event in the first room of the game would show the message endlessly:
This is likely related to YoYoGames/GameMaker-Bugs#4726, but I'm attaching another sample here.
game_restart
,room_goto
or similar after a game end/crash would work.These changes only work on browsers that support
requestAnimation
/cancelAnimationFrame
, which should be fine since the browser vendors implemented these features more than a decade ago. The only affected browser is Opera Mini but I'm not sure GameMaker would run on it at all since it lacks so many features.