Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fallback to default language within internal linking suggestions if All Languages is selected, changed language error message #557

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Sep 12, 2023

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

  • Use getDefaultLanguage of Site when sys_language_uid is -1.

Test instructions

This PR can be tested by following these steps:

  • Pull branch
  • Set a content element to "All languages"
  • Check if the internal linking suggestions are now based on the default language

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #554

…ions if All Languages is selected, changed language error message
@RinyVT RinyVT force-pushed the bugfix/554-all-languages branch from e7c8381 to d515174 Compare September 18, 2023 09:47
@RinyVT RinyVT merged commit 8c25328 into main Sep 18, 2023
9 checks passed
@RinyVT RinyVT deleted the bugfix/554-all-languages branch September 18, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidArgumentException Language -1 does not exist on site in InternalLinkingSuggestion
1 participant