Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NanoXplore NG-Ultra support #1397

Open
wants to merge 145 commits into
base: master
Choose a base branch
from
Open

Adding NanoXplore NG-Ultra support #1397

wants to merge 145 commits into from

Conversation

mmicko
Copy link
Member

@mmicko mmicko commented Nov 27, 2024

This PR includes work done in longer period that adds support for NG-Ultra architecture of NanoXplore using Himbaechel API.
It was done as part of Project Beyond and files needed for building chip database are now available at https://github.com/YosysHQ-GmbH/prjbeyond-db/.
Bitstream is exported in JSON format that is supported by Impulse tool from NanoXplore and it is used to generate binary bitstreams or additionally modify design.

@mmicko mmicko requested a review from gatecat November 27, 2024 12:41
Copy link
Member

@gatecat gatecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some review comments that I think would get this up to mergeable quality.

himbaechel/uarch/ng-ultra/bitstream.cc Outdated Show resolved Hide resolved
himbaechel/uarch/ng-ultra/bitstream.cc Outdated Show resolved Hide resolved
himbaechel/uarch/ng-ultra/bitstream.cc Outdated Show resolved Hide resolved
himbaechel/uarch/ng-ultra/bitstream.cc Outdated Show resolved Hide resolved
himbaechel/uarch/ng-ultra/pack.h Outdated Show resolved Hide resolved
himbaechel/uarch/ng-ultra/pack.cc Show resolved Hide resolved
himbaechel/uarch/ng-ultra/ng_ultra.cc Outdated Show resolved Hide resolved
himbaechel/uarch/ng-ultra/ng_ultra.cc Outdated Show resolved Hide resolved
himbaechel/uarch/ng-ultra/ng_ultra.cc Outdated Show resolved Hide resolved
himbaechel/uarch/ng-ultra/gen/arch_gen.py Outdated Show resolved Hide resolved
@mmicko
Copy link
Member Author

mmicko commented Nov 29, 2024

All changes done, please note that clangformat changes TESTABLE_PRIVATE macro (that is just "private") in wierd way, so had to manually undo those changes, will see if I can overcome this for future. Commited just changes for this architecture, but note there are some in common code and in other archs.

@gatecat
Copy link
Member

gatecat commented Nov 29, 2024

You can use /* clang-format off */ and /* clang-format on */ to selectively disable formatting, that's probably the best solution here

@mmicko
Copy link
Member Author

mmicko commented Nov 29, 2024

Now it is fine, it needed to include next line as well otherwise formatting is again wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants