fix(Category/SaveBefore):fixed passing null to json_decode

YotpoLtd · Nov 18, 2022 · 59c1a75 · 59c1a75
1 parent 51ebef5
commit 59c1a75
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/Observer/Category/SaveBefore.php b/Observer/Category/SaveBefore.php
@@ -87,15 +87,16 @@ public function execute(Observer $observer)
                 $categoryId
             );
 
+        $productIdToPositionInCategoryStringMapBeforeSave = $this->request->getParam('vm_category_products');
+        if ($productIdToPositionInCategoryStringMapBeforeSave === null) {
+            return;
+        }
+
         $productIdToPositionInCategoryMapBeforeSave =
             json_decode(
-                $this->request->getParam('vm_category_products'),
+                $productIdToPositionInCategoryStringMapBeforeSave,
                 true
             );
-        if ($productIdToPositionInCategoryMapBeforeSave === null) {
-            return;
-        }
-
         $productIdsInCategoryBeforeSave = array_keys($productIdToPositionInCategoryMapBeforeSave);
         $productsAddedToCategory = array_diff($productIdsInCategoryBeforeSave, $currentProductIdsInCategory);
         $productsDeletedFromCategory = array_diff($currentProductIdsInCategory, $productIdsInCategoryBeforeSave);