YTPOS-125 adjusted name to get correct site preference value #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted variable names to be consistent
mikefromgrr
approved these changes
Oct 23, 2024
| if ('productInformationFromMaster' in localeConfigObject.custom) { | ||
| yotpoConfig.productInformationFromMaster = localeConfigObject.custom.productInformationFromMaster; | ||
| if ('yotpoProductInformationFromMaster' in localeConfigObject.custom) { | ||
| yotpoConfig.yotpoProductInformationFromMaster = localeConfigObject.custom.yotpoProductInformationFromMaster; |
There was a problem hiding this comment.
Interestingly, the localeConfigObject originates from Custom Object with type-id=yotpoConfiguration. That Custom Object defined in Metadata\metadata\meta\custom-objecttype-definitions.xml has no definition for the attribute yotpoProductInformationFromMaster (and no trace of the old attribute productInformationFromMaster). While this is safe code because of the in check, these lines will never be hit unless the actual object definition is updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and updated variable names to be consistent