Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Packages NuGet Registry #26

Closed
FelixS90 opened this issue Nov 15, 2023 · 3 comments
Closed

Use GitHub Packages NuGet Registry #26

FelixS90 opened this issue Nov 15, 2023 · 3 comments
Assignees

Comments

@FelixS90
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
Using GitHub Packages NuGet registry to push from libczicompress build in GitHub action. Consumption in czishrink from there.

Additional context
https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-nuget-registry
https://github.blog/changelog/2022-12-09-packages-fine-grained-permissions-and-organization-level-publishing-are-now-available-for-the-github-packages-nuget-registry/

@FelixS90 FelixS90 self-assigned this Nov 15, 2023
@m-ringler
Copy link
Contributor

m-ringler commented Nov 17, 2023

@FelixS90 One thing that we should keep in mind here: we don't want to unduly complicate branching and forking the repo. I'd say that

  • It must remain possible to use the CziShrink CI build and the czicompress CI build of a repo fork without setting up a personal access token and/or altering the contents of the forked repo.
  • It should remain easy to substitute a locally built libczicompressc nuget package in CziShrink for development purposes.
  • It should remain possible to build CziShrink on your local dev box without authenticating to the github nuget package registry.

@m-ringler
Copy link
Contributor

Also, if the libczicompressc nuget package gets a 'life of its own', we should make the nuspec a bit more complete (esp. description) and address the warnings issued by nuget pack.

@FelixS90 FelixS90 linked a pull request Nov 17, 2023 that will close this issue
11 tasks
@FelixS90
Copy link
Collaborator Author

Closing. Staying with current way of deployment - in combination with #7 .

@FelixS90 FelixS90 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants