-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub Packages NuGet Registry #30
Conversation
<copyright>© Carl Zeiss Microscopy GmbH and others. All rights reserved.</copyright> | ||
<repository type="git" url="https://github.com/ZEISS/czicompress" branch="main" commit="40a2ba8489544626c2481ca95177b3235b5c0de7" /> | ||
<repository type="git" url="https://github.com/ZEISS/czicompress" commit="$token_commit$"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do it like https://www.fuget.org/packages/Microsoft.CodeAnalysis.PublicApiAnalyzers/3.3.2, i.e. only specifying commit (and not branch) - mainly to avoid issues with "hierarchical" branch names and full refs (like origin/refs/heads/). On top, branches are only pointers - commits are enough.
Background: NuGet/NuGetGallery#7537
<title>Native runtimes for CZI ZStd compression</title> | ||
<authors>Carl Zeiss Microscopy</authors> | ||
<owners>Carl Zeiss Microscopy</owners> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
owners deprecated.
Description
Publish libczicompressc as NuGet to GH Packages Registry
Make czishrink consume libczicompressc as NuGet from GH Packages Registry
Fixes #26
As outlined in the issue above, this is intended:
Type of change
Note: Dev/Deployment related breaking change only, no functionality-related breaking change!
See https://github.com/ZEISS/czicompress/blob/26-use-github-packages-nuget-registry/czishrink/README.md#build
How Has This Been Tested?
Cloud:
Manual pipeline runs of .NET Build (CziShrink) and CMake Build (czicompress)
Published libczicompressc as NuGet to GH Package Registry in CMake Build (czicompress) | Run 6883977121 - package
On Windows (locally):
Local
nuget restore
anddotnet restore
Local build + unit test execution
Manual test (start application)
TBD: Check #26 (comment)) (also in the context of https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions)
Checklist: