Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Packages NuGet Registry #30

Closed
wants to merge 16 commits into from

Conversation

FelixS90
Copy link
Collaborator

@FelixS90 FelixS90 commented Nov 17, 2023

Description

Publish libczicompressc as NuGet to GH Packages Registry
Make czishrink consume libczicompressc as NuGet from GH Packages Registry

Fixes #26

As outlined in the issue above, this is intended:

Type of change

How Has This Been Tested?

Cloud:
Manual pipeline runs of .NET Build (CziShrink) and CMake Build (czicompress)
Published libczicompressc as NuGet to GH Package Registry in CMake Build (czicompress) | Run 6883977121 - package
On Windows (locally):
Local nuget restore and dotnet restore
Local build + unit test execution
Manual test (start application)

TBD: Check #26 (comment)) (also in the context of https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions)

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of czicompress following the README (Versioning) depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@FelixS90 FelixS90 linked an issue Nov 17, 2023 that may be closed by this pull request
@FelixS90 FelixS90 self-assigned this Nov 17, 2023
@FelixS90 FelixS90 added the cla Contributor License Agreement sent to Admin label Nov 17, 2023
<copyright>© Carl Zeiss Microscopy GmbH and others. All rights reserved.</copyright>
<repository type="git" url="https://github.com/ZEISS/czicompress" branch="main" commit="40a2ba8489544626c2481ca95177b3235b5c0de7" />
<repository type="git" url="https://github.com/ZEISS/czicompress" commit="$token_commit$"/>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it like https://www.fuget.org/packages/Microsoft.CodeAnalysis.PublicApiAnalyzers/3.3.2, i.e. only specifying commit (and not branch) - mainly to avoid issues with "hierarchical" branch names and full refs (like origin/refs/heads/). On top, branches are only pointers - commits are enough.

Background: NuGet/NuGetGallery#7537

<title>Native runtimes for CZI ZStd compression</title>
<authors>Carl Zeiss Microscopy</authors>
<owners>Carl Zeiss Microscopy</owners>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owners deprecated.

@FelixS90 FelixS90 closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use GitHub Packages NuGet Registry
1 participant