-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not overwrite OriginalCompressionMethod anymore in czicompress #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriwiz
requested review from
ptahmose,
sdierg,
m-ringler and
DaveyJonesBitPail
November 10, 2023 07:56
chriwiz
force-pushed
the
do-not-overwrite-original-compression-method
branch
from
November 10, 2023 07:59
19f3d56
to
94c3965
Compare
m-ringler
changed the title
Do not overwrite OriginalCompressionMethod anymore
Do not overwrite OriginalCompressionMethod anymore in czicompress
Nov 10, 2023
m-ringler
requested changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to Logo.png should probably be reverted
chriwiz
force-pushed
the
do-not-overwrite-original-compression-method
branch
from
November 10, 2023 10:08
89e7da9
to
2bd5563
Compare
chriwiz
force-pushed
the
do-not-overwrite-original-compression-method
branch
from
November 10, 2023 10:45
fee3c07
to
e8d9572
Compare
m-ringler
approved these changes
Nov 10, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the past we accidently used the OriginalCompressionMethod to also store the "current" compression method, although it should be only used to store the compression method at the time of the acquisition.
This PR fixes this issue and uses the newly introduced metadata "CurrentCompressionParameters" and "OriginalCompressionParameters" while ignoring the "OriginalEncodingQuality" metadata.
Type of change
How Has This Been Tested?
I tested my changes by automated unit tests.
Checklist: