Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite OriginalCompressionMethod anymore in czicompress #12

Merged
merged 6 commits into from
Nov 10, 2023

Conversation

chriwiz
Copy link
Contributor

@chriwiz chriwiz commented Nov 10, 2023

Description

In the past we accidently used the OriginalCompressionMethod to also store the "current" compression method, although it should be only used to store the compression method at the time of the acquisition.
This PR fixes this issue and uses the newly introduced metadata "CurrentCompressionParameters" and "OriginalCompressionParameters" while ignoring the "OriginalEncodingQuality" metadata.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I tested my changes by automated unit tests.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of czicompress following the README (Versioning) depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@chriwiz chriwiz force-pushed the do-not-overwrite-original-compression-method branch from 19f3d56 to 94c3965 Compare November 10, 2023 07:59
@m-ringler m-ringler added the cla Contributor License Agreement sent to Admin label Nov 10, 2023
@m-ringler m-ringler changed the title Do not overwrite OriginalCompressionMethod anymore Do not overwrite OriginalCompressionMethod anymore in czicompress Nov 10, 2023
Copy link
Contributor

@m-ringler m-ringler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to Logo.png should probably be reverted

czicompress/tests/test_copyoperation.cpp Show resolved Hide resolved
czicompress/tests/test_copyoperation.cpp Outdated Show resolved Hide resolved
czishrink/netczicompress/Assets/Logo.png Outdated Show resolved Hide resolved
@chriwiz chriwiz force-pushed the do-not-overwrite-original-compression-method branch from 89e7da9 to 2bd5563 Compare November 10, 2023 10:08
@chriwiz chriwiz force-pushed the do-not-overwrite-original-compression-method branch from fee3c07 to e8d9572 Compare November 10, 2023 10:45
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
netczicompress 83% 73% 538
Summary 83% (980 / 1180) 73% (248 / 338) 538

@chriwiz chriwiz merged commit a4588ec into main Nov 10, 2023
10 checks passed
@m-ringler m-ringler deleted the do-not-overwrite-original-compression-method branch November 10, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants