Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use older Ubuntu for Linux build for "more compatible binaries" #3

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Oct 23, 2023

Description

  • Use an older Ubuntu-version for the runner in order to have the binaries being linked to an older C/C++ runtime. This should increase compatibility with older distros.
  • Fix an error in the Github-actions-yaml (which had the funny effect of using the wrong caches I think).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally - I tested the resulting Linux-binary on a Debian-bullseye-box, and it worked fine. The current binary (built with 'ubuntu-latest') did not work.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of czicompress following the README (Versioning) depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested a review from a team October 23, 2023 22:13
@ptahmose ptahmose changed the title add -static-libstd++ use older Ubuntu for Linux build for "more compatible binaries" Oct 24, 2023
@m-ringler m-ringler added the cla Contributor License Agreement sent to Admin label Oct 24, 2023
@ptahmose ptahmose merged commit 029973e into ZEISS:main Oct 24, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants