Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path-filtering for PRs #36

Closed
wants to merge 1 commit into from
Closed

Conversation

m-ringler
Copy link
Contributor

@m-ringler m-ringler commented Nov 22, 2023

CURRENTLY NOT WORKING

This seems to have the fundamental issue that individual jobs are required as status checks and not complete workflows.
See #37 which should have all checks passed, but is waiting for checks that were skipped.

Description

This PR makes Build and CodeQL job runs conditional in pull requests.
Czicompress-specific jobs are only run, when code that may affect czicompress is altered; and czishrink-specific jobs are only run for czishrink code changes.

Subproject changes are detected with a new reusable workflow in subproject-changes.yml.

Goals: Simplify PR validation, reduce energy consumption.

Fixes #29

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.

@m-ringler m-ringler self-assigned this Nov 23, 2023
@m-ringler m-ringler requested review from FelixS90 and a team November 23, 2023 08:10
@m-ringler m-ringler added enhancement New feature or request cla Contributor License Agreement sent to Admin CI/CD labels Nov 23, 2023
@m-ringler m-ringler force-pushed the feature/cicd-path-filters branch from 1ecb02c to cfe961d Compare November 23, 2023 08:22
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #36 (a498ca0) into main (fa6f38d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   77.64%   77.64%           
=======================================
  Files          58       58           
  Lines        1897     1897           
  Branches      121      121           
=======================================
  Hits         1473     1473           
  Misses        401      401           
  Partials       23       23           
Components Coverage Δ
czicompress 66.75% <ø> (ø)
czishrink 80.39% <ø> (ø)

@m-ringler m-ringler force-pushed the feature/cicd-path-filters branch 14 times, most recently from a3c22c2 to cb3613a Compare November 23, 2023 10:42
@m-ringler m-ringler mentioned this pull request Nov 23, 2023
@m-ringler m-ringler force-pushed the feature/cicd-path-filters branch from cb3613a to a498ca0 Compare November 23, 2023 21:06
@DaveyJonesBitPail
Copy link
Contributor

This looks good! I would perhaps add an additional distinction between czishrink and the installer within its subfolder. I'll take a try at adding this after I finish remaining installer changes unless you get to it first.

Copy link
Contributor

@ptahmose ptahmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but I have to confess, it complicates matters (CI/CD-matters) considerably. I mean - I am sure it solves an issue, but at the price of increased complexity. This is not always a good deal I reckon.

@m-ringler
Copy link
Contributor Author

Abandoning this PR. It's not working.

@m-ringler m-ringler closed this Jan 11, 2024
@m-ringler m-ringler deleted the feature/cicd-path-filters branch November 25, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD cla Contributor License Agreement sent to Admin enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of path filters for GitHub actions
4 participants