-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path-filtering for PRs #36
Conversation
1ecb02c
to
cfe961d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 77.64% 77.64%
=======================================
Files 58 58
Lines 1897 1897
Branches 121 121
=======================================
Hits 1473 1473
Misses 401 401
Partials 23 23
|
a3c22c2
to
cb3613a
Compare
cb3613a
to
a498ca0
Compare
This looks good! I would perhaps add an additional distinction between czishrink and the installer within its subfolder. I'll take a try at adding this after I finish remaining installer changes unless you get to it first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but I have to confess, it complicates matters (CI/CD-matters) considerably. I mean - I am sure it solves an issue, but at the price of increased complexity. This is not always a good deal I reckon.
Abandoning this PR. It's not working. |
CURRENTLY NOT WORKING
This seems to have the fundamental issue that individual jobs are required as status checks and not complete workflows.
See #37 which should have all checks passed, but is waiting for checks that were skipped.
Description
This PR makes Build and CodeQL job runs conditional in pull requests.
Czicompress-specific jobs are only run, when code that may affect czicompress is altered; and czishrink-specific jobs are only run for czishrink code changes.
Subproject changes are detected with a new reusable workflow in subproject-changes.yml.
Goals: Simplify PR validation, reduce energy consumption.
Fixes #29
Type of change
How Has This Been Tested?
Checklist: