Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt unit tests for PR 42 Add custom formatting for TimeSpan #43

Merged

Conversation

DaveyJonesBitPail
Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail commented Dec 1, 2023

Description

There were some minor UT adaptations that I thought I had pushed before merging #42.

  • Freeze Mock of ITimeFormatter to return empty string within AggregateStatisticsViewModelTests because we want to test invariant of formatting.
  • Remove ShouldBeEquivalent options to ignore Duration when comparing AggregateStatisticsViewModel and AggregateStatistics record.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe the tests that you ran to verify your changes.
Provide instructions to reproduce.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of czicompress following the README (Versioning) depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@DaveyJonesBitPail DaveyJonesBitPail added bug Something isn't working czishrink The issue or PR affects czishrink .NET Pull requests that update .net code labels Dec 1, 2023
@DaveyJonesBitPail DaveyJonesBitPail self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #43 (487e36a) into main (f03a169) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   77.72%   77.72%           
=======================================
  Files          59       59           
  Lines        1917     1917           
  Branches      122      122           
=======================================
  Hits         1490     1490           
  Misses        403      403           
  Partials       24       24           
Components Coverage Δ
czicompress 66.75% <ø> (ø)
czishrink 80.45% <ø> (ø)

@DaveyJonesBitPail DaveyJonesBitPail added the cla Contributor License Agreement sent to Admin label Dec 1, 2023
@DaveyJonesBitPail DaveyJonesBitPail marked this pull request as ready for review December 1, 2023 13:58
@DaveyJonesBitPail DaveyJonesBitPail merged commit 3e4dc8d into main Dec 1, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla Contributor License Agreement sent to Admin czishrink The issue or PR affects czishrink .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants