Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to dotnet SDK 8.0.204 #57

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Upgrade to dotnet SDK 8.0.204 #57

merged 2 commits into from
Apr 15, 2024

Conversation

m-ringler
Copy link
Contributor

@m-ringler m-ringler commented Apr 15, 2024 •
edited
Loading

  • Bump dotnet SDK version to 8.0.204
  • Bump Wix Toolset version to 5.0.0, fixing 'Package 'WixToolset.Sdk' 4.0.3 has a known high severity vulnerability, '

@m-ringler m-ringler added cla Contributor License Agreement sent to Admin CI/CD dependencies Pull requests that update a dependency file czishrink The issue or PR affects czishrink .NET Pull requests that update .net code labels Apr 15, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2024 •
edited
Loading

Codecov Report

Merging #57 (22f6b38) into main (28c813c) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   77.87%   77.77%   -0.11%     
==========================================
  Files          59       59              
  Lines        1921     1921              
  Branches      122      122              
==========================================
- Hits         1496     1494       -2     
- Misses        401      403       +2     
  Partials       24       24
Components Coverage Δ
czicompress 66.75% <ø> (ø)
czishrink 80.50% <ø> (-0.13%) ⬇️

@m-ringler m-ringler force-pushed the feature/dotnet-8.0.204 branch from e7c8dac to 9d8f57f Compare April 15, 2024 13:48
@m-ringler m-ringler force-pushed the feature/dotnet-8.0.204 branch from c857629 to 22f6b38 Compare April 15, 2024 14:15
@m-ringler m-ringler marked this pull request as ready for review April 15, 2024 14:21
@m-ringler m-ringler requested a review from a team April 15, 2024 14:25
DaveyJonesBitPail
DaveyJonesBitPail approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There shouldn't be any breaking changes across these wix versions so I will "blindly" approve.

I will test the new installer and if issues crop up I will prepare a PR to fix.

@m-ringler m-ringler merged commit 7e918e0 into main Apr 15, 2024
19 checks passed
@m-ringler m-ringler deleted the feature/dotnet-8.0.204 branch April 15, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveyJonesBitPail DaveyJonesBitPail DaveyJonesBitPail approved these changes

Assignees
No one assigned
Labels
CI/CD cla Contributor License Agreement sent to Admin czishrink The issue or PR affects czishrink dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-ringler @DaveyJonesBitPail