Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CziShrink #6

Merged
merged 33 commits into from
Nov 9, 2023
Merged

Add CziShrink #6

merged 33 commits into from
Nov 9, 2023

Conversation

m-ringler
Copy link
Contributor

Description

This PR adds the CziShrink desktop application to the repo at /czishrink.
The C/C++ app and library are moved to the /czicompress folder.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested with automated tests and manually.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of czicompress following the README (Versioning) depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@m-ringler m-ringler added the cla Contributor License Agreement sent to Admin label Nov 7, 2023
@m-ringler m-ringler self-assigned this Nov 7, 2023
@m-ringler m-ringler requested review from FelixS90 and a team November 7, 2023 20:18
@m-ringler m-ringler added the enhancement New feature or request label Nov 7, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@m-ringler
Copy link
Contributor Author

m-ringler commented Nov 7, 2023

@FelixS90 Can you allow the actions that are needed for the .NET build?
It fails with [Error: .github#L1](https://github.com/ZEISS/czicompress/commit/968436f288da18d6f975dc8c6c83841975d3ef22#annotation_15492784809) m-ringler/get-xpath@v3, irongut/[email protected], and marocchino/sticky-pull-request-comment@v2 are not allowed to be used in ZEISS/czicompress. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following: fsfe/reuse-action@*, oxsecurity/megalinter/*. I am not allowed to see or change the repo settings.

We'll also need to change branch policies to not require 'Analyze (cpp)' but 'CodeQL (czicompress) / Analyze CPP (cpp)'.

ptahmose
ptahmose previously approved these changes Nov 7, 2023
Copy link
Contributor

@ptahmose ptahmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great!

@swg08 swg08 self-requested a review November 7, 2023 21:56
.github/workflows/czicompress_cmake.yml Outdated Show resolved Hide resolved
.github/workflows/czicompress_cmake.yml Outdated Show resolved Hide resolved
.github/workflows/czicompress_cmake.yml Show resolved Hide resolved
.github/workflows/czishrink_codeql.yml Show resolved Hide resolved
.github/workflows/czishrink_codeql.yml Outdated Show resolved Hide resolved
czishrink/README.md Outdated Show resolved Hide resolved
czicompress/README.md Outdated Show resolved Hide resolved
czishrink/THIRD_PARTY_LICENSES_ARTIFACT_DISTRIBUTION.txt Outdated Show resolved Hide resolved
czishrink/libczicompressc/THIRD_PARTY_LICENSES.txt Outdated Show resolved Hide resolved
This is necessary for them to be usable in branch protection rules.
czishrink/netczicompress/Models/PInvokeFileProcessor.cs Dismissed Show dismissed Hide dismissed
czishrink/netczicompress/Models/PInvokeFileProcessor.cs Dismissed Show dismissed Hide dismissed
czishrink/netczicompress/Models/PInvokeFileProcessor.cs Dismissed Show dismissed Hide dismissed
@m-ringler m-ringler requested a review from FelixS90 November 9, 2023 10:25
* Added czishrink specific artifact distributions

* Add transitive czishrink notices
@FelixS90
Copy link
Collaborator

FelixS90 commented Nov 9, 2023

@FelixS90 Can you allow the actions that are needed for the .NET build? It fails with [Error: .github#L1](https://github.com/ZEISS/czicompress/commit/968436f288da18d6f975dc8c6c83841975d3ef22#annotation_15492784809) m-ringler/get-xpath@v3, irongut/[email protected], and marocchino/sticky-pull-request-comment@v2 are not allowed to be used in ZEISS/czicompress. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following: fsfe/reuse-action@*, oxsecurity/megalinter/*. I am not allowed to see or change the repo settings.

We'll also need to change branch policies to not require 'Analyze (cpp)' but 'CodeQL (czicompress) / Analyze CPP (cpp)'.

Addressed in #8 .

@FelixS90 FelixS90 merged commit 0f59b4f into ZEISS:main Nov 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants