-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CziShrink #6
Conversation
…ore-adding-czishrink Move czicompress source to subfolder
Add CziShrink
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
@FelixS90 Can you allow the actions that are needed for the .NET build? We'll also need to change branch policies to not require 'Analyze (cpp)' but 'CodeQL (czicompress) / Analyze CPP (cpp)'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - great!
czishrink/libczicompressc/THIRD_PARTY_LICENSES_ARTIFACT_DISTRIBUTION.txt
Outdated
Show resolved
Hide resolved
This is necessary for them to be usable in branch protection rules.
Co-authored-by: Felix Scheffler <[email protected]>
Co-authored-by: Felix Scheffler <[email protected]>
Co-authored-by: Felix Scheffler <[email protected]>
Co-authored-by: Felix Scheffler <[email protected]>
* Added czishrink specific artifact distributions * Add transitive czishrink notices
Addressed in #8 . |
Description
This PR adds the CziShrink desktop application to the repo at /czishrink.
The C/C++ app and library are moved to the /czicompress folder.
Type of change
How Has This Been Tested?
Tested with automated tests and manually.
Checklist: