Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL warning #60

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix CodeQL warning #60

merged 2 commits into from
Jul 22, 2024

Conversation

m-ringler
Copy link
Contributor

@m-ringler m-ringler commented Jul 19, 2024

Description

Check null before dereferencing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Github actions

Checklist

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I updated the version of czicompress
    • Bug fix -> PATCH
  • New and existing unit tests pass locally with my changes.

@m-ringler m-ringler added bug Something isn't working cla Contributor License Agreement sent to Admin czicompress The issue or PR affects czicompress labels Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (35c5c16) to head (fdd82a8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   77.87%   77.77%   -0.11%     
==========================================
  Files          59       59              
  Lines        1921     1921              
  Branches      122      122              
==========================================
- Hits         1496     1494       -2     
- Misses        401      403       +2     
  Partials       24       24              
Components Coverage Δ
czicompress 66.75% <ø> (ø)
czishrink 80.50% <ø> (-0.13%) ⬇️

@m-ringler m-ringler requested a review from a team July 19, 2024 10:43
@m-ringler m-ringler self-assigned this Jul 22, 2024
@m-ringler m-ringler marked this pull request as ready for review July 22, 2024 08:53
@m-ringler m-ringler merged commit 4c5195a into main Jul 22, 2024
21 of 22 checks passed
@m-ringler m-ringler deleted the m-ringler-patch-1 branch November 25, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla Contributor License Agreement sent to Admin czicompress The issue or PR affects czicompress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants