Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libcurl and enable SSL by default (on Windows) #111

Merged
merged 24 commits into from
Sep 3, 2024

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Sep 2, 2024

Description

  • Update the curl version to 8.9.1 (note: this only affects builds where LIBCZI_BUILD_PREFER_EXTERNALPACKAGE_LIBCURL is set to OFF)
  • enable SSL by default on Windows (using SChannel)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested a review from a team September 2, 2024 21:45
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.16%. Comparing base (3567211) to head (cdf38e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files          85       85           
  Lines       10685    10685           
=======================================
  Hits         7070     7070           
  Misses       3615     3615           
Flag Coverage Δ
windows-latest 66.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Sep 2, 2024
Src/CMakeLists.txt Show resolved Hide resolved
@ptahmose ptahmose merged commit ec7376c into ZEISS:main Sep 3, 2024
15 checks passed
@ptahmose ptahmose deleted the jbl/update_private_ssl branch September 3, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants