add Azure-SDK-based stream-object #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `cmake.yml` to streamline Windows dependency installation by removing redundant commands. Enhanced `azureblobinputstream.cpp` with `DefaultAzureCredential` initialization and improved `cout` formatting. Modified `AzureBlobInputStream::Read` to handle HTTP status codes correctly, ensuring accurate byte count reporting. Cleaned up commented-out code for better readability.
Added [[noreturn]] attribute to static methods in CziParse.cpp and CziParse.h for better compiler optimizations and code clarity. Introduced a new constructor in azureblobinputstream.cpp to handle std::wstring URLs, utilizing Utilities::convertUtf8ToWchar_t. Implemented TokenizeAzureUriString in utilities.cpp to parse std::wstring key-value pairs into a std::map. Updated CMakeLists.txt to include test_azureblobstream.cpp in libCZI_UnitTests. Added tests for TokenizeAzureUriString in test_azureblobstream.cpp. Updated azureblobinputstream.h and utilities.h to declare new functions and include necessary headers.
- Modify `AzureBlobInputStream` constructor to accept URL instead of filename. - Add `CreateWithDefaultAzureCredential` method for service client creation. - Implement `DetermineAuthenticationMode` in constructor for auth mode. - Update `Read` method with size/offset checks and detailed error handling. - Add `DetermineServiceUrl` method for constructing service URL. - Introduce `AuthenticationMode` enum for different auth methods. - Update `azureblobinputstream.h` with new methods and enum declarations. - Adjust commented-out code and preprocessor directives for debugging/future use.
Refactored `azureblobinputstream.cpp` for better readability and maintainability. Key changes include: - Used iterator for `containername` and `blobname` checks in `tokenized_file_name` map. - Moved UTF-8 string conversion closer to usage. - Removed commented-out code and unnecessary debug print statements. - Determined `service_url` using `AzureBlobInputStream::DetermineServiceUrl`. - Streamlined initialization of `serviceClient_` and `blockBlobClient_`. - Improved clarity and efficiency of `CreateWithDefaultAzureCredential` method.
- Removed `#include <iostream>` from `azureblobinputstream.cpp`. - Modified `CreateWithDefaultAzureCredential`: - Use `make_shared` for `DefaultAzureCredential`. - Create `BlobServiceClient` as a local variable. - Use local `BlobServiceClient` for `BlobContainerClient` and `BlockBlobClient`. - Assign `BlockBlobClient` to `blockBlobClient_` using `unique_ptr`. - Updated `Read` method to remove commented-out line. - Simplified `~AzureBlobInputStream` by removing empty block. - Commented out `serviceClient_` in `azureblobinputstream.h`.
Introduced support for connection string-based authentication in Azure Blob storage. Added static constants for various URI keys to improve code readability and maintainability. Implemented a new constructor and method `CreateWithConnectionString` for handling connection string-based authentication. Updated `DetermineAuthenticationMode` to be static and handle the new auth mode. Renamed member variable `blockBlobClient_` to `block_blob_client_` for consistency. Improved error messages in `DetermineServiceUrl`.
Added SPDX identifiers for copyright and LGPL-3.0-or-later license. Included a separator line for clarity.
Modified `cmake.yml` to prevent termination of the Azurite process after running tests. This ensures the Azurite process remains active for the subsequent code-coverage step.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 66.16% 65.51% -0.66%
==========================================
Files 85 86 +1
Lines 10685 10892 +207
==========================================
+ Hits 7070 7136 +66
- Misses 3615 3756 +141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DaveyJonesBitPail
previously approved these changes
Sep 19, 2024
Co-authored-by: DaveyJonesBitPail <[email protected]>
m-aXimilian
previously approved these changes
Sep 19, 2024
DaveyJonesBitPail
previously approved these changes
Sep 19, 2024
Co-authored-by: DaveyJonesBitPail <[email protected]>
Co-authored-by: DaveyJonesBitPail <[email protected]>
m-aXimilian
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How Has This Been Tested?
locally, with CZIcmd, unittests and by beta-users
Checklist: