Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workload identity in azure reader #120

Merged

Conversation

Relax2Zero
Copy link
Contributor

@Relax2Zero Relax2Zero commented Oct 18, 2024

Description

fix workload identity in azure reader

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally build.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested review from ptahmose and a team October 18, 2024 13:19
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Oct 18, 2024
Copy link
Contributor

@ptahmose ptahmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.47%. Comparing base (515abf6) to head (74c272e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Src/libCZI/StreamsLib/azureblobinputstream.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   65.47%   65.47%           
=======================================
  Files          86       86           
  Lines       10898    10898           
=======================================
  Hits         7136     7136           
  Misses       3762     3762           
Flag Coverage Δ
windows-latest 65.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptahmose ptahmose merged commit 8474da3 into ZEISS:main Oct 18, 2024
15 of 16 checks passed
@ptahmose ptahmose requested a review from a team October 18, 2024 14:40
@Relax2Zero Relax2Zero deleted the bugfix/corrent-workload-identity-mapping branch October 18, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants