Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jbl/1013574 pyramidtype #65

Merged
merged 12 commits into from
Sep 13, 2023
Merged

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Sep 8, 2023

Description

Make some "obscure and questionable" field in the subblock-data accessible to libCZI.
To my current understanding, this "pyramid-type" field has no importance, but it turned out that some applications seem to evaluate it. So - for the purpose of "replicating the exact same behavior with libCZI-created files", it is necessary to set this accordingly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally and a unit-test is added

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose marked this pull request as ready for review September 8, 2023 13:09
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #65 (76392f4) into main (4a3533f) will increase coverage by 0.05%.
The diff coverage is 71.01%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   50.23%   50.29%   +0.05%     
==========================================
  Files          78       78              
  Lines       16088    16116      +28     
==========================================
+ Hits         8082     8105      +23     
- Misses       8006     8011       +5     
Flag Coverage Δ
windows-latest 50.29% <71.01%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Src/libCZI/CziParse.h 100.00% <ø> (ø)
Src/libCZI/CziReaderWriter.h 100.00% <ø> (ø)
Src/libCZI/CziUtils.h 80.00% <ø> (ø)
Src/libCZI/libCZI_Pixels.h 55.00% <ø> (ø)
Src/libCZI/CZIReader.cpp 65.21% <50.00%> (-0.30%) ⬇️
Src/libCZI/CziReaderWriter.cpp 79.76% <50.00%> (-0.12%) ⬇️
Src/libCZI/CziWriter.cpp 84.88% <63.41%> (+0.05%) ⬆️
Src/libCZI/CziUtils.cpp 65.13% <85.71%> (+3.03%) ⬆️
Src/libCZI/CziParse.cpp 71.68% <100.00%> (+0.12%) ⬆️
Src/libCZI/CziSubBlockDirectory.h 100.00% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ptahmose ptahmose requested review from FelixS90 and soyers September 11, 2023 12:38
@ptahmose ptahmose merged commit c9954d5 into ZEISS:main Sep 13, 2023
15 checks passed
@ptahmose ptahmose deleted the jbl/1013574-pyramidtype branch November 3, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants