-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StatusBar.asm #2
Open
johnwelter
wants to merge
9
commits into
ZaneDubya:master
Choose a base branch
from
johnwelter:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix to make sure the game doesn't reset when adding an energy tank
welp, just realized that RTS call is unnecessary, since the Xplus4 call already has it. but other than that, this is a necessity to get the game to work |
johnwelter
commented
Feb 6, 2024
@@ -122,7 +122,8 @@ LE18B: sta Sprite00RAM+3,x ; | |||
LE18E: sec ; | |||
LE18F: sbc #$0A ;Find x coord of next energy tank. | |||
LE191: sta $00 ; | |||
|
|||
jmp Xplus4 | |||
rts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RTS call isn't needed, it's handled in the Xplus4 call
added common area code for original decomp to save on label changes
simplifying the code to exclude all the L tags, and make unknown placeholders
replaced all LC/LD label calls with proper placeholders, removed LC/LD label tags
clearing up some obfuscations, adding comments, removed more L labels in the main code
resetting back to master branch changes
added Xplus4 call to ensure the game doesn't reset when adding an energy tank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix to make sure the game doesn't reset when adding an energy tank