suggestion: Use the same ChainVerifier for downloaded and submitted blocks #5533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-enhancement
github-actions
bot
added
the
C-trivial
teor2345
force-pushed
the
submitblock-chain-verifier
branch
from
38464e0 to
634fff1
Compare
teor2345
commented
Nov 2, 2022
teor2345
commented
Nov 2, 2022
teor2345
commented
Nov 2, 2022
teor2345
commented
Nov 2, 2022
teor2345
commented
Nov 2, 2022
teor2345
commented
Nov 2, 2022
5 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## submitblock #5533 +/- ##
===============================================
+ Coverage 79.25% 79.28% +0.02%
===============================================
Files 305 305
Lines 37884 37879 -5
===============================================
+ Hits 30026 30031 +5
+ Misses 7858 7848 -10 |
arya2
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra isn't really designed to use multiple instances of the same verifiers. It might work, but it is easier to design, test, and maintain if we just have one running verifier of each kind.
This is a suggestion for PR #5526.
Solution
See the explanations I'm going to post on each part of the PR.
Review
@arya2 wrote the original PR.
I'm happy to revert any of these changes that aren't needed - let me know what you think!
Reviewer Checklist