-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rpc): Use populated state in more RPC snapshot tests #6700
Conversation
e19d34a
to
38607ce
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6700 +/- ##
==========================================
+ Coverage 78.01% 78.05% +0.03%
==========================================
Files 310 310
Lines 40740 40757 +17
==========================================
+ Hits 31784 31812 +28
+ Misses 8956 8945 -11 |
Failed due to #5819 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The target branch changed when I was finishing the review on GitHub, which was interesting to observe because the code suddenly changed, and I just kept reading. :D
Motivation
We're getting lower test coverage in some of our snapshot tests, because they accidentally use a mock state. We get more coverage by actually calling the state.
Solution
Review
This is a test cleanup, it isn't urgent at all.
Reviewer Checklist