-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(ci): Use a single CI workflow for tests #8575
Conversation
63340c3
to
567b7a2
Compare
567b7a2
to
3147d20
Compare
7439890
to
1eec396
Compare
This is an initial implementation to solve the re-building of our Docker image, which is being built multiple times by our Github Actions. This is meant to fix -> devops: Build CI Docker runs twice for every PR #7816
aeb26ef
to
6d8fbbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes workflow patches for unit tests, but it doesn't do so for integration tests. Why is that?
Co-authored-by: Marek <[email protected]>
The changelog is confusing, but I removed the unit tests patches, and renamed and reused the same patch files for integration tests, those are the new |
Co-authored-by: Marek <[email protected]>
@upbqdn after merging your last suggestions, this will require re-approval. Thanks! |
@upbqdn Oops! I had to revert one of the suggestions as I had forgotten the reasoning behind it. The job is called Also, changing the job name here would then require 2 merge rules instead of 1: Now:
This would also be a breaking change, requiring other PRs to be updated. I'd prefer to avoid that in this refactor. |
Co-authored-by: Marek <[email protected]>
Motivation
This is an initial implementation to solve the re-building of our Docker image, which is being built multiple times by our Github Actions, causing elevated costs across multiple services.
Fixes #7816
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Complex Code or Requirements
ci-tests.yml
with its respectives.patch.yml
and.patch-external.yml
to initialize the unit tests and integration tests from a single place, effectively using a single Docker image build process.Solution
Run tests
starter workflowIntegration Tests on GCP
andDocker Unit Tests
to callable workflowsIntegration Tests on GCP
andDocker Unit Tests
patches files into a single patch file forRun tests
Testing
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
This must be followed by #8374 to effectively reduce our costs.