change(scan): Remove support for starting the scanner at zebrad startup

[upbqdn]

Motivation

Close #8582.

PR Author Checklist

Check before marking the PR as ready for review:

• Will the PR name make sense to users?
• Does the PR have a priority label?
• Have you added or updated tests?
• Is the documentation up to date?
• Is there a summary in the CHANGELOG?
• Can these changes be split into multiple PRs?

Solution

• Remove the code that starts the scanner from the start command.

Testing

Let's move the the integration tests out of zebrad in #8593 once we have the new binary.

Reviewer Checklist

Check before approving the PR:

• Does the PR scope match the ticket?
• Are there enough tests to make sure it works? Do the tests cover the PR motivation?
• Are all the PR blockers dealt with?
  PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

• change(scan): Move integration tests for scanner out of zebrad #8593
• Documentation changes for the new zebra-scanner binary #8586
• Testing the new zebra-scanner binary #8585

[arya2]

@upbqdn There's a small merge conflict.

[upbqdn]

Resolved.

[oxarbitrage]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed