Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: General conditional compilation attributes #8602

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jun 11, 2024

Motivation

See https://blog.rust-lang.org/2024/05/06/check-cfg.html

This change in beta causes CI errors in docs compilation.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

Solution

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@upbqdn upbqdn added P-Critical 🚑 rust Pull requests that update Rust code labels Jun 11, 2024
@upbqdn upbqdn self-assigned this Jun 11, 2024
@upbqdn upbqdn requested a review from a team as a code owner June 11, 2024 16:13
@upbqdn upbqdn requested review from arya2 and removed request for a team June 11, 2024 16:13
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Jun 11, 2024
See https://blog.rust-lang.org/2024/05/06/check-cfg.html

The conditional compilation flags for tor were superfluous as we can
make do fine with using only features.
@upbqdn upbqdn force-pushed the remove-tor-flag branch from c375a1c to e5d573e Compare June 11, 2024 16:38
@upbqdn upbqdn removed the extra-reviews This PR needs at least 2 reviews to merge label Jun 11, 2024
@upbqdn upbqdn requested a review from a team as a code owner June 11, 2024 16:42
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Jun 11, 2024
@upbqdn upbqdn changed the title fix(network): Remove general conditional compilation attributes fix: General conditional compilation attributes Jun 11, 2024
arya2
arya2 previously approved these changes Jun 11, 2024
@upbqdn upbqdn removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jun 11, 2024
@oxarbitrage
Copy link
Contributor

This PR should merge as it is only failing in Windows.

@arya2
Copy link
Contributor

arya2 commented Jun 12, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jun 12, 2024

refresh

✅ Pull request refreshed

@arya2
Copy link
Contributor

arya2 commented Jun 12, 2024

This PR should merge as it is only failing in Windows.

It was the extra-reviews label that github-actions added.

@mergify mergify bot merged commit 158d687 into main Jun 12, 2024
192 of 193 checks passed
@mergify mergify bot deleted the remove-tor-flag branch June 12, 2024 01:04
@mpguerra mpguerra removed the extra-reviews This PR needs at least 2 reviews to merge label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Critical 🚑 rust Pull requests that update Rust code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants