-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scanner): Add a new zebra-scanner
binary
#8608
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, it may need to select the env-filter
feature on tracing-subscriber, but otherwise I see no blockers.
Thank you!
This should be merged only after the next release. #8321 |
1f056c6
to
3bb5a9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
01fdf97
to
23f72e9
Compare
Motivation
We want to run the blockchain scanner in a new binary and process.
Close #8581
Close #8633
PR Author Checklist
Check before marking the PR as ready for review:
Solution
Use
zebra_state::init_read_only
to runzebra_scan::spawn_init
from a new binary.Testing
Arguments:
I am using the following command to run the scanner with the ZECPAGES key, open the grpc port and see the logs:
Output:
Review
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work