Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump zcash_primitives, orchard and zcash_proofs #8615

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jun 17, 2024

Solution

  • Bump orchard from 0.7 to 0.8.
  • Bump zcash_primitives from 0.14 to 0.15
    • The new version moves the methods previously in zcash_primitives::consensus::Parameters to zcash_protocol::consensus::NetworkConstants, which is now blanket-implemented for Zebra's Network, so I removed our implementation of zcash_primitives::consensus::Parameters because of conflicting method names. The blanket implementation of NetworkConstants returns hard-coded HRPs, so we lost the ability to return custom ones. We don't need custom HRPs now, so I removed them.
  • Bump zcash_proofs from 0.14 to 0.15.

Tests

Existing tests should suffice.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@upbqdn upbqdn added A-dependencies Area: Dependency file updates rust Pull requests that update Rust code labels Jun 17, 2024
@upbqdn upbqdn self-assigned this Jun 17, 2024
@upbqdn upbqdn requested review from a team as code owners June 17, 2024 13:44
@upbqdn upbqdn requested review from oxarbitrage and removed request for a team June 17, 2024 13:44
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jun 17, 2024
@upbqdn upbqdn removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jun 17, 2024
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jun 17, 2024
@upbqdn upbqdn requested review from arya2 and removed request for oxarbitrage June 17, 2024 18:43
@upbqdn upbqdn changed the title Bump zcash_primitives, orchard and zcash_proofs chore: Bump zcash_primitives, orchard and zcash_proofs Jun 17, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@upbqdn
Copy link
Member Author

upbqdn commented Jun 19, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jun 19, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 95e4d09 into main Jun 19, 2024
140 checks passed
@mergify mergify bot deleted the bump-ecc-deps branch June 19, 2024 16:31
@upbqdn upbqdn mentioned this pull request Jun 28, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG rust Pull requests that update Rust code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants