-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump zcash_primitives
, orchard
and zcash_proofs
#8615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upbqdn
added
A-dependencies
Area: Dependency file updates
rust
Pull requests that update Rust code
labels
Jun 17, 2024
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jun 17, 2024
upbqdn
removed
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jun 17, 2024
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jun 17, 2024
upbqdn
changed the title
Bump
chore: Bump Jun 17, 2024
zcash_primitives
, orchard
and zcash_proofs
zcash_primitives
, orchard
and zcash_proofs
arya2
reviewed
Jun 17, 2024
arya2
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-dependencies
Area: Dependency file updates
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
rust
Pull requests that update Rust code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
orchard
from 0.7 to 0.8.zcash_primitives
from 0.14 to 0.15zcash_primitives::consensus::Parameters
tozcash_protocol::consensus::NetworkConstants
, which is now blanket-implemented for Zebra'sNetwork
, so I removed our implementation ofzcash_primitives::consensus::Parameters
because of conflicting method names. The blanket implementation ofNetworkConstants
returns hard-coded HRPs, so we lost the ability to return custom ones. We don't need custom HRPs now, so I removed them.zcash_proofs
from 0.14 to 0.15.Tests
Existing tests should suffice.
PR Author's Checklist
The PR provides a CHANGELOG summary.PR Reviewer's Checklist