-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openapi): Add defaults to rpc methods where needed #8616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, the only part I'm unsure about is the request_id_property
type_
field being "number" when the default value is an alphanumeric.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
There's a small merge conflict in the changelog, we could put changelog entries in the PR description and move them to the release drafter once the changes are merged instead of updating the changelog file in PRs if we get too many merge conflicts.
Motivation
Several of the rpc methods need default implementations so a sample response can be created in the openapi spec.
Solution
Add defaults where needed, complete hardcoded list of rpc methods in the openapi utility. Add a random string as the request ID.
Tests
Manually tested.
PR Author's Checklist
PR Reviewer's Checklist