-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(book): Describes custom Testnets in the Zebra book #8636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuring custom Testnet genesis hashes, refactors check for compatible custom Testnets, adds a TODO, and uses the default testnet when there's an empty or default `testnet_parameters` field in Zebra's network config.
… connections on Regtest to a footnote.
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jun 21, 2024
upbqdn
previously approved these changes
Jun 27, 2024
13 tasks
Co-authored-by: Marek <[email protected]>
arya2
commented
Jun 27, 2024
arya2
commented
Jun 27, 2024
Co-authored-by: Arya <[email protected]>
upbqdn
previously approved these changes
Jun 27, 2024
13 tasks
arya2
commented
Jun 27, 2024
upbqdn
approved these changes
Jun 27, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to document Zebra's custom Testnets in the Zebra book.
Closes #8588.
Solution
Related changes:
genesis_hash
to Zebra's configuration.testnet_parameters
section is included in the config with default testnet values and no network name.Tests
Updates the latest stored config with a configured genesis hash.
PR Author's Checklist
PR Reviewer's Checklist