Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(mergify): use the new configuration format and keys #9018

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

gustavovalverde
Copy link
Member

Motivation

We tried using GitHub Merge queue without success, as this would have limited our actual automations, the use of multiple queues, and other flexibilities that Mergify gives us.

Additionally, Mergify already supports the Rulesets, allowing us to continue using their engine without having to change our actual GitHub configuration

Specifications & References

Solution

  • Transfer the pull_request_rules to the new priority_rules
  • Use defaults for pull_request_rules and queue_rules
  • Set the priority of high, medium and low, as required.

Tests

Follow-up Work

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@gustavovalverde gustavovalverde added A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑 labels Nov 14, 2024
@gustavovalverde gustavovalverde self-assigned this Nov 14, 2024
@gustavovalverde gustavovalverde requested a review from a team as a code owner November 14, 2024 11:54
@gustavovalverde gustavovalverde requested review from upbqdn and removed request for a team November 14, 2024 11:54
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 14, 2024
@gustavovalverde gustavovalverde changed the title ref(mergify): use the the configuration format and keys ref(mergify): use the new configuration format and keys Nov 14, 2024
@gustavovalverde gustavovalverde enabled auto-merge (squash) November 14, 2024 12:02
@gustavovalverde gustavovalverde merged commit ac90773 into main Nov 14, 2024
95 checks passed
@gustavovalverde gustavovalverde deleted the fix-mergify-queue branch November 14, 2024 12:03
@arya2 arya2 mentioned this pull request Dec 5, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant