Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(diagnostics): Updates error messages to include inner error types #9066

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

conradoplg
Copy link
Collaborator

Motivation

This closes #8961 but it's actually an attempt to debug the lwd-send-transaction test failure in CI so it's a draft for now.

Specifications & References

Solution

Tests

Follow-up Work

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 changed the title add: add consensus validation reason to error messages change(diagnostics): Updates error messages to include inner error types Dec 3, 2024
arya2
arya2 previously approved these changes Dec 3, 2024
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be a good change to merge into main.

Update: I see that's already the plan after we're done debugging the test. 👍

@conradoplg conradoplg marked this pull request as ready for review December 4, 2024 14:01
@conradoplg conradoplg requested review from a team as code owners December 4, 2024 14:01
@conradoplg conradoplg requested review from oxarbitrage and removed request for a team December 4, 2024 14:01
@conradoplg
Copy link
Collaborator Author

I think this would be a good change to merge into main.

Update: I see that's already the plan after we're done debugging the test. 👍

I got what I wanted so I think we can merge this now if you want; I moved it out of draft.

@conradoplg conradoplg requested a review from a team as a code owner December 4, 2024 14:28
@conradoplg conradoplg requested review from upbqdn and removed request for a team December 4, 2024 14:28
@conradoplg
Copy link
Collaborator Author

I went ahead and added it for all #[from] and #[source]s

mergify bot added a commit that referenced this pull request Dec 4, 2024
@mergify mergify bot merged commit a3bb1e2 into main Dec 4, 2024
145 of 147 checks passed
@mergify mergify bot deleted the show-consensus-validation-reason branch December 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Specify why a transaction did not pass consensus validation
2 participants