Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(test): Add serialized NU5 blocks to test vectors #9098

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Dec 21, 2024

Motivation

Close #2409, #9090 and #9088.

Solution

Tests

  • Remove unneeded test for fake V5 txs.
  • Use real V5 txs where appropriate. This uncovered some malfunctioning tests, for example 34e985b.
  • Fix failing tests. This turned out to be much more work than I expected.
  • Use Network::iter instead of only Mainnet txs.

Follow-up Work

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@upbqdn upbqdn added C-testing Category: These are tests P-Medium ⚡ labels Dec 21, 2024
@upbqdn upbqdn self-assigned this Dec 21, 2024
@upbqdn upbqdn requested a review from a team as a code owner December 21, 2024 00:32
@upbqdn upbqdn requested review from oxarbitrage and removed request for a team December 21, 2024 00:32
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 21, 2024
@upbqdn upbqdn removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 21, 2024
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 21, 2024
@upbqdn upbqdn removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-testing Category: These are tests P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve fake_v5_transaction_with_orchard_actions_has_inputs_and_outputs test
1 participant