Merge pull request #146 from ZdruzenieSTROM/138-team-edit-form

138 team edit form

kos/forms.py

@@ -130,6 +130,9 @@ def __init__(self, *args, **kwargs):
 
 class EditTeamForm(forms.Form):
     """Form na úpravu tímových údajov"""
+    team_name = forms.CharField(
+        widget=forms.TextInput(attrs={'class': 'form-control main-input'}),
+        label='Názov tímu')
     team_member_1 = forms.CharField(
         widget=forms.TextInput(attrs={'class': 'form-control main-input'}),
         label='1. člen tímu')
@@ -146,4 +149,8 @@ class EditTeamForm(forms.Form):
         widget=forms.TextInput(attrs={'class': 'form-control main-input'}),
         label='5. člen tímu', required=False
     )
-    is_online = forms.BooleanField(required=False)
+    is_online = forms.BooleanField(
+        required=False,
+        widget=forms.CheckboxInput(attrs={'class': 'checkbox-input'}),
+        label='Chcem riešiť online'
+    )

kos/models.py

@@ -297,6 +297,15 @@ class Meta:
     is_public = models.BooleanField(
         verbose_name='Tím je verejný', default=True)
 
+    @property
+    def editable(self) -> bool:
+        """
+        Vráti, či je ešte možné robiť zmeny v tíme.
+        Aktuálne tímom dovoľujeme meniť meno a členov tímu
+        do konca šifrovačky. Zákaz menenia toho, či je tím
+        online je implementovaný inde."""
+        return self.game.year.end > now()
+
     def __str__(self):
         return f'{self.name}'
 

kos/templates/kos/change_profile.html

@@ -17,4 +17,15 @@ <h2>Zmena údajov tímu</h2>
 {% else %}
     <div class="answer-alert error">Platbu za súťaž zatiaľ neevidujeme.</div>
 {% endif %}
+
+<script>
+// TODO: Solve this more properly and also check for this on backend
+// Hack to remove the disable attribute of is_online field on submit
+// Otherwise the value of is_online is not sent at post and the team
+// is marked as offline upon e. g. changing their name after the 
+// registration ends but before the game concludes.
+$("form").submit(function() {
+    $("input").removeAttr("disabled");
+});
+</script>
 {% endblock %}

kos/views.py

@@ -407,6 +407,7 @@ def get(self, request, *args, **kwargs):
     def get_initial(self):
         team = self.get_team()
         init_dict = {
+            'team_name': team.name,
             'is_online': team.is_online
         }
         for i, member in enumerate(team.members.all()):
@@ -421,25 +422,31 @@ def get_context_data(self, **kwargs):
         context['paid'] = (
             team.paid if hasattr(team, 'paid') else False
         )
-        context['disabled'] = team.game.year.registration_deadline < now()
+        context['disabled'] = not team.editable
         return context
 
     def post(self, request, *args, **kwargs):
         team = self.get_team()
         if team is None:
             return redirect('kos:game')
-        if team.game.year.registration_deadline < now():
+        if not team.editable:
             messages.error(
                 request, 'Tieto údaje nie je možné meniť po skončení registrácie')
             return redirect('kos:change-profile')
+        # TODO: Check that the team did not change their is_online
+        # status after the registration deadline. Currently this
+        # is only disabled on frontend but can be bypassed.
         return super().post(request, *args, **kwargs)
 
     def get_form(self, form_class=None):
         form = super().get_form(form_class)
         team = self.get_team()
-        if team.game.year.registration_deadline < now():
+        if not team.editable:
             for field in form.fields.values():
                 field.widget.attrs['disabled'] = True
+        # Po konci registracie uz nechceme timu dovolit menit ci je online
+        if team.game.year.registration_deadline < now():
+            form.fields['is_online'].widget.attrs['disabled'] = True
         return form
 
     def form_valid(self, form):