Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font sizes overhaul - first usages #162

Merged
merged 8 commits into from
Nov 11, 2023
Merged

Font sizes overhaul - first usages #162

merged 8 commits into from
Nov 11, 2023

Conversation

rtrembecky
Copy link
Collaborator

first work of #127 - we can potentially leave rest to beginners

@rtrembecky rtrembecky requested a review from Matushl November 11, 2023 10:42
@rtrembecky rtrembecky mentioned this pull request Nov 11, 2023
Copy link
Member

@Matushl Matushl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nejake navrhy na zvazenie ale asi pohodinda

// TODO(#127): 10px (10/16=0.625rem). ale treba asi nastavit height celeho menu itemu, nech to neskace
border-bottom: 0.3rem solid black;
border-color: black;
border-width: 10px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls no

@@ -70,7 +74,9 @@ const MenuMainItem: FC<{caption: string; url: string}> = ({caption, url}) => {

return (
<div className={clsx(styles.menuItem, active && styles.active)}>
<Link href={url}>{caption}</Link>
<Typography variant="h2" textTransform="uppercase">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podla mna variant="button1"

src/theme.ts Outdated
Comment on lines 34 to 38
const _theme = createTheme({
typography: {
fontFamily: ['Poppins', 'sans-serif'].join(','),
},
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zvazil by som mozno pridat

    // Disable variants
    button: undefined,

@rtrembecky rtrembecky merged commit eff2703 into master Nov 11, 2023
1 check passed
@rtrembecky rtrembecky deleted the font-sizes-overhaul branch November 11, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants