Add banner info #214
Add banner info #214
Conversation
| } | ||
|
|
||
| .p { | ||
| padding-bottom: 1rem; |
There was a problem hiding this comment.
hm, neviem, ako to maju klasicke p-cka, tipol by som ale margin, pretoze margin sa prekryva... ze medzi
<Box mb={1} />
<Box mt={1} />je margin 1 a nie 2. ale tuto pri statickych strankach asi v pohode 😄
There was a problem hiding this comment.
anyway kludne na toto uz asi mozeme zacat pouzivat Typography a sx, kaslat na konzistenciu 😄 no to je jedno
There was a problem hiding this comment.
to by som este vytvoril nejaky samostatny task na to aby sme nastylovali cely ten Markdown component nejak konzistetne s nasim designom a neriesil to uz v tomto PR
| // TODO: skusime to opravit v API - `history_events` je nespravne vygenerovane ako `any` | ||
| type OurCompetition = Omit<Competition, 'history_events'> & {history_events: Event[]} |
There was a problem hiding this comment.
ja som asi rozmyslal, ze na taketo typove overrides mozeme zatial pouzivat typy z @/types/api, ktore budu prepisovat @/types/api/generated... ale nikdy to nebolo poriadne dotiahnute do konca. plus generovanie typov na BE podla mna teraz vobec nefunguje a bude treba upgradnut django-typomatic a prepisat to... meeh 😢
och ale naco komentujem presunuty kod... a komentar celkom mozne odo mna
Closes: #165